src/Migration/Sources/Firebase.php (1)

816-819: Minor: Inconsistent exception message casing.

The exception message uses 'Not implemented' (lowercase 'i'), while other sources (CSV, JSON, NHost) use 'Not Implemented' (uppercase 'I'). Consider standardizing for consistency.

Proposed fix

 protected function exportGroupIntegrations(int $batchSize, array $resources): void
 {
-    throw new \Exception('Not implemented');
+    throw new \Exception('Not Implemented');
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Migration/Sources/Firebase.php` around lines 816 - 819, The exception
message in Firebase::exportGroupIntegrations currently uses 'Not implemented';
update the throw in the protected method exportGroupIntegrations(int $batchSize,
array $resources) to throw the same canonical message 'Not Implemented' used by
other sources so the exception casing is consistent across implementations
(locate the throw new \Exception(...) inside exportGroupIntegrations and change
the string).

src/Migration/Sources/Appwrite.php (2)

2065-2073: Consider implementing pagination using $batchSize parameter.

The $batchSize parameter is unused and exportPlatforms fetches all platforms in a single API call. Other export methods implement pagination for scalability. If the platforms API supports pagination, consider adding it:

-private function exportPlatforms(array $consoleHeaders): void
+private function exportPlatforms(array $consoleHeaders, int $batchSize = 25): void
 {
-    $response = $this->call('GET', '/projects/' . $this->project . '/platforms', $consoleHeaders);
+    $lastPlatform = null;
+
+    while (true) {
+        $queries = [Query::limit($batchSize)];
+        if ($lastPlatform) {
+            $queries[] = Query::cursorAfter($lastPlatform);
+        }
+        
+        $response = $this->call('GET', '/projects/' . $this->project . '/platforms?' . http_build_query(['queries' => $queries]), $consoleHeaders);
+        // ... process platforms ...
+        
+        if (count($response['platforms']) < $batchSize) {
+            break;
+        }
+    }

If the API doesn't support pagination or platform counts are expected to be small, consider documenting this or removing $batchSize from the method signature for clarity.

Also applies to: 2105-2129

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Migration/Sources/Appwrite.php` around lines 2065 - 2073,
exportGroupIntegrations currently ignores the $batchSize parameter and calls
exportPlatforms which fetches all platforms at once; update exportPlatforms
(and/or the call site in exportGroupIntegrations) to implement pageable fetching
using $batchSize (e.g., loop with offset/page tokens until no more results) and
yield/return batches compatible with exportWithConsoleHeaders, or if the
Appwrite platforms API has no pagination, remove $batchSize from
exportGroupIntegrations’ signature or add a code comment documenting the lack of
pagination; reference the exportGroupIntegrations method, exportPlatforms
function, and exportWithConsoleHeaders helper when making the change.

---

2043-2058: Consider using $resourceIds parameter for consistency.

The $resourceIds parameter is unused (as flagged by static analysis). Other report* methods like reportAuth, reportStorage, etc. use this parameter to filter results. For consistency, consider adding filtering support:

 private function reportIntegrations(array $resources, array &$report, array $resourceIds = []): void
 {
     if (\in_array(Resource::TYPE_PLATFORM, $resources)) {
         $consoleHeaders = $this->getConsoleHeaders();

         if ($consoleHeaders === null) {
             return;
         }

         try {
-            $response = $this->call('GET', '/projects/' . $this->project . '/platforms', $consoleHeaders);
+            $queries = [];
+            if (!empty($resourceIds[Resource::TYPE_PLATFORM])) {
+                // Note: Add filtering if the API supports it
+            }
+            $response = $this->call('GET', '/projects/' . $this->project . '/platforms', $consoleHeaders);
             $report[Resource::TYPE_PLATFORM] = $response['total'] ?? 0;

Alternatively, remove the unused parameter if filtering isn't applicable for platforms.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Migration/Sources/Appwrite.php` around lines 2043 - 2058, The
reportIntegrations method currently ignores the $resourceIds parameter; either
use it to filter the platforms count or remove the unused parameter. To fix,
update reportIntegrations (method name: reportIntegrations) to apply
$resourceIds when calling the platforms endpoint (e.g. include IDs or a filter
in the GET to '/projects/{project}/platforms' and compute
$report[Resource::TYPE_PLATFORM] from the filtered response) or delete the
$resourceIds parameter from the method signature and all callers if platform
filtering is not supported; ensure the try/catch and assignment to
$report[Resource::TYPE_PLATFORM] remain consistent with other report* methods
(e.g., reportAuth/reportStorage) when implementing the change.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

src/Migration/Destinations/Appwrite.php (1)

2222-2231: Duplicate detection query may have a race condition.

The findOne check followed by createDocument is not atomic. In high-concurrency scenarios, two imports could pass the existence check simultaneously and both attempt to create the platform. The DuplicateException catch on line 2250 handles this correctly as a fallback, so the logic is safe but could log misleading "already exists" messages for legitimate race conditions.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Migration/Destinations/Appwrite.php` around lines 2222 - 2231, The
duplicate-detection using $this->dbForPlatform->findOne(...) followed by an
early return causes misleading "Platform already exists" status under race
conditions; remove the early return and allow the subsequent createDocument call
(and its DuplicateException handler) to determine the final outcome, or change
the early-path to only short-circuit when you can guarantee exclusivity;
specifically update the block around $this->dbForPlatform->findOne,
Query::equal(...) and $resource->setStatus(Resource::STATUS_SKIPPED, ...) so it
does not preemptively set SKIPPED on a non-atomic check but instead relies on
the existing DuplicateException handling (the catch near the createDocument
call) to set the SKIPPED status for real duplicates caused by race conditions.

src/Migration/Sources/Appwrite.php (2)

2235-2249: ⚠️ Potential issue | 🟠 Major

Initialize platform report and honor resourceIds filtering.

On Line 2240, returning early leaves \$report[Resource::TYPE_PLATFORM] unset. Also \$resourceIds is currently unused, so filtered reports can be incorrect.

💡 Suggested logic fix

 private function reportIntegrations(array $resources, array &$report, array $resourceIds = []): void
 {
-    if (\in_array(Resource::TYPE_PLATFORM, $resources)) {
-        $consoleHeaders = $this->getConsoleHeaders();
+    if (!\in_array(Resource::TYPE_PLATFORM, $resources, true)) {
+        return;
+    }
+
+    $report[Resource::TYPE_PLATFORM] = 0;
+    $consoleHeaders = $this->getConsoleHeaders();

-        if ($consoleHeaders === null) {
-            return;
-        }
+    if ($consoleHeaders === null) {
+        return;
+    }

-        try {
-            $response = $this->call('GET', '/projects/' . $this->project . '/platforms', $consoleHeaders);
-            $report[Resource::TYPE_PLATFORM] = $response['total'] ?? 0;
-        } catch (\Throwable) {
-            $report[Resource::TYPE_PLATFORM] = 0;
-        }
-    }
+    try {
+        $response = $this->call('GET', '/projects/' . $this->project . '/platforms', $consoleHeaders);
+        $platforms = $response['platforms'] ?? [];
+        if (!empty($resourceIds[Resource::TYPE_PLATFORM])) {
+            $allowed = \array_flip((array) $resourceIds[Resource::TYPE_PLATFORM]);
+            $platforms = \array_filter($platforms, fn (array $p): bool => isset($allowed[$p['$id'] ?? '']));
+            $report[Resource::TYPE_PLATFORM] = \count($platforms);
+            return;
+        }
+        $report[Resource::TYPE_PLATFORM] = $response['total'] ?? \count($platforms);
+    } catch (\Throwable) {
+        // keep fallback 0
+    }
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Migration/Sources/Appwrite.php` around lines 2235 - 2249, The
reportIntegrations method currently skips setting
$report[Resource::TYPE_PLATFORM] when getConsoleHeaders() returns null and never
respects the $resourceIds filter; update reportIntegrations to always initialize
$report[Resource::TYPE_PLATFORM] (e.g., to 0) before the headers check and, when
$resourceIds is non-empty, only populate the platform count if
Resource::TYPE_PLATFORM is included in $resourceIds (otherwise leave it as 0 or
skip); keep using getConsoleHeaders() and the existing call('GET',
'/projects/'.$this->project.'/platforms', $consoleHeaders) inside the try/catch
to set the count and preserve the catch behavior for exceptions.

---

2277-2284: ⚠️ Potential issue | 🟠 Major

Use paginated export for platforms and thread batchSize through.

exportGroupIntegrations() accepts \$batchSize, but exportPlatforms() currently performs a single non-paginated request and does not apply root-resource filtering. This can truncate exported platforms.

📌 Directional refactor

 protected function exportGroupIntegrations(int $batchSize, array $resources): void
 {
-    if (\in_array(Resource::TYPE_PLATFORM, $resources)) {
+    if (\in_array(Resource::TYPE_PLATFORM, $resources, true)) {
         $this->exportWithConsoleHeaders(
             Resource::TYPE_PLATFORM,
             Transfer::GROUP_INTEGRATIONS,
-            $this->exportPlatforms(...)
+            fn (array $consoleHeaders) => $this->exportPlatforms($consoleHeaders, $batchSize)
         );
     }
 }

-private function exportPlatforms(array $consoleHeaders): void
+private function exportPlatforms(array $consoleHeaders, int $batchSize): void
 {
-    $response = $this->call('GET', '/projects/' . $this->project . '/platforms', $consoleHeaders);
-    ...
+    // paginate with limit + cursorAfter until page size < $batchSize
+    // and respect rootResourceId/rootResourceType when TYPE_PLATFORM is targeted
 }

For Appwrite REST API v1 / PHP SDK v19, confirm whether `GET /projects/{projectId}/platforms` supports pagination (`limit`, `cursorAfter`) via `queries`, and provide the exact request/query format.

Also applies to: 2343-2367

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Migration/Sources/Appwrite.php` around lines 2277 - 2284, The
exportPlatforms call inside exportGroupIntegrations must be converted to a
paginated exporter that respects the passed $batchSize and filters by root
resource: update exportPlatforms to accept (int $batchSize, ?string
$rootResource = null) and implement paginated requests to Appwrite platforms
using the SDK's queries (e.g. include limit=$batchSize and cursorAfter handling)
so each page is yielded/exported; then change the exportGroupIntegrations
invocation to pass $batchSize and the appropriate root resource when calling
$this->exportPlatforms(...) so Transfer::GROUP_INTEGRATIONS export will iterate
all pages rather than a single non-paginated request.

src/Migration/Sources/Appwrite.php (2)

2235-2251: ⚠️ Potential issue | 🟠 Major

Initialize platform report count and honor resourceIds in integrations report.

reportIntegrations() can return without setting \$report[Resource::TYPE_PLATFORM], and filtered reports ignore \$resourceIds, which can produce incorrect totals.

💡 Proposed fix

 private function reportIntegrations(array $resources, array &$report, array $resourceIds = []): void
 {
-    if (\in_array(Resource::TYPE_PLATFORM, $resources)) {
-        $consoleHeaders = $this->getConsoleHeaders();
-
-        if ($consoleHeaders === null) {
-            return;
-        }
-
-        try {
-            $response = $this->call('GET', '/projects/' . $this->project . '/platforms', $consoleHeaders);
-            $report[Resource::TYPE_PLATFORM] = $response['total'] ?? 0;
-        } catch (\Throwable) {
-            $report[Resource::TYPE_PLATFORM] = 0;
-        }
+    if (!\in_array(Resource::TYPE_PLATFORM, $resources, true)) {
+        return;
+    }
+
+    $report[Resource::TYPE_PLATFORM] = 0;
+    $consoleHeaders = $this->getConsoleHeaders();
+    if ($consoleHeaders === null) {
+        return;
+    }
+
+    try {
+        $response = $this->call('GET', '/projects/' . $this->project . '/platforms', $consoleHeaders);
+        $platforms = $response['platforms'] ?? [];
+
+        if (!empty($resourceIds[Resource::TYPE_PLATFORM])) {
+            $allowed = \array_flip((array) $resourceIds[Resource::TYPE_PLATFORM]);
+            $platforms = \array_filter(
+                $platforms,
+                fn (array $platform): bool => isset($allowed[$platform['$id'] ?? ''])
+            );
+            $report[Resource::TYPE_PLATFORM] = \count($platforms);
+            return;
+        }
+
+        $report[Resource::TYPE_PLATFORM] = $response['total'] ?? \count($platforms);
+    } catch (\Throwable) {
+        // keep fallback 0
     }
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Migration/Sources/Appwrite.php` around lines 2235 - 2251, Initialize
$report[Resource::TYPE_PLATFORM] = 0 at the start of reportIntegrations(), and
when fetching platforms via call('GET', '/projects/' . $this->project .
'/platforms', $consoleHeaders) honor the $resourceIds filter: if $resourceIds is
non-empty, inspect $response['data'] (the returned platform items) and set
$report[Resource::TYPE_PLATFORM] to the count of items whose '$id' (or 'id') is
in $resourceIds; otherwise fall back to $response['total'] ?? 0. Keep the
existing try/catch and ensure the catch leaves $report[Resource::TYPE_PLATFORM]
as 0.

---

2281-2290: ⚠️ Potential issue | 🟠 Major

Use \$batchSize and paginate platform export (current flow can truncate data).

exportGroupIntegrations() receives \$batchSize, but exportPlatforms() performs a single list call with no cursor loop and no root-platform filter handling. This can export only the first page and ignore targeted root exports.

💡 Proposed fix

 protected function exportGroupIntegrations(int $batchSize, array $resources): void
 {
     if (\in_array(Resource::TYPE_PLATFORM, $resources)) {
         $this->exportWithConsoleHeaders(
             Resource::TYPE_PLATFORM,
             Transfer::GROUP_INTEGRATIONS,
-            $this->exportPlatforms(...)
+            fn (array $consoleHeaders) => $this->exportPlatforms($consoleHeaders, $batchSize)
         );
     }
 }

 /**
  * `@throws` AppwriteException
  */
-private function exportPlatforms(array $consoleHeaders): void
+private function exportPlatforms(array $consoleHeaders, int $batchSize): void
 {
-    $response = $this->call('GET', '/projects/' . $this->project . '/platforms', $consoleHeaders);
-
-    if (empty($response['platforms'])) {
-        return;
-    }
-
-    $platforms = [];
-
-    foreach ($response['platforms'] as $platform) {
-        $platforms[] = new Platform(
-            $platform['$id'] ?? '',
-            $platform['type'] ?? '',
-            $platform['name'] ?? '',
-            $platform['key'] ?? '',
-            $platform['store'] ?? '',
-            $platform['hostname'] ?? '',
-            createdAt: $platform['$createdAt'] ?? '',
-            updatedAt: $platform['$updatedAt'] ?? '',
-        );
-    }
-
-    $this->callback($platforms);
+    $cursor = null;
+    while (true) {
+        $queries = [Query::limit($batchSize)];
+
+        if ($this->rootResourceId !== '' && $this->rootResourceType === Resource::TYPE_PLATFORM) {
+            $queries[] = Query::equal('$id', $this->rootResourceId);
+            $queries[] = Query::limit(1);
+        } elseif ($cursor !== null) {
+            $queries[] = Query::cursorAfter($cursor);
+        }
+
+        $response = $this->call(
+            'GET',
+            '/projects/' . $this->project . '/platforms',
+            $consoleHeaders,
+            ['queries' => $queries]
+        );
+
+        $current = $response['platforms'] ?? [];
+        if (empty($current)) {
+            break;
+        }
+
+        $platforms = [];
+        foreach ($current as $platform) {
+            $platforms[] = new Platform(
+                $platform['$id'] ?? '',
+                $platform['type'] ?? '',
+                $platform['name'] ?? '',
+                $platform['key'] ?? '',
+                $platform['store'] ?? '',
+                $platform['hostname'] ?? '',
+                createdAt: $platform['$createdAt'] ?? '',
+                updatedAt: $platform['$updatedAt'] ?? '',
+            );
+        }
+
+        $this->callback($platforms);
+
+        if ($this->rootResourceId !== '' && $this->rootResourceType === Resource::TYPE_PLATFORM) {
+            break;
+        }
+
+        $cursor = $current[\count($current) - 1]['$id'] ?? null;
+        if (\count($current) < $batchSize) {
+            break;
+        }
+    }
 }

For Appwrite API/SDK v19, what is the exact supported pagination format for GET /v1/projects/{projectId}/platforms (queries[] with limit/cursorAfter), and how should those queries be encoded for REST requests?

Also applies to: 2351-2375

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Migration/Sources/Appwrite.php` around lines 2281 - 2290,
exportGroupIntegrations currently passes $batchSize but exportPlatforms does a
single list call; update exportPlatforms to loop using $batchSize and Appwrite
v19 cursor pagination: call listPlatforms repeatedly with queries[] params
"limit(<batchSize>)" and "cursorAfter(<lastId>)" (encoded as
queries[]=limit(<n>)&queries[]=cursorAfter(<id>) in REST) until no more results,
and honor any root-platform filter when building the queries; reference the
exportGroupIntegrations and exportPlatforms methods and replace the single-call
list with a cursor-based loop that updates cursorAfter from the last item each
iteration.